Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-20602: Do not clear sys.flags and sys.float_info during shutdown#8096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytzZackerySpytz commentedJul 4, 2018•
edited by bedevere-bot
Loading

There is no need to clear these immutable objects during shutdown.

https://bugs.python.org/issue20602

@ZackerySpytzZackerySpytz requested a review froma teamJuly 4, 2018 22:59
@serhiy-storchakaserhiy-storchaka requested review fromtiran and removed request fora teamJuly 5, 2018 12:38
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ZackerySpytz
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@serhiy-storchaka: please review the changes made to this pull request.

Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

The PR has been dormant for a while. Do you want to land it in 3.8?

@ZackerySpytz
Copy link
ContributorAuthor

Thanks for the review,@tiran.

For what it's worth, I would like to see this land in 3.8.

@tiran
Copy link
Member

@ZackerySpytz Could you please rebase the PR to kick off another test run?

There is no need to clear these immutable objects during shutdown.
Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@encukouencukou merged commit249b7d5 intopython:masterMay 30, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
…ythonGH-8096)There is no need to clear these immutable objects during shutdown.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tirantirantiran approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@brettcannonbrettcannonAwaiting requested review from brettcannon

@encukouencukouAwaiting requested review from encukou

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrently

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@warsawwarsawAwaiting requested review from warsaw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz@bedevere-bot@tiran@serhiy-storchaka@encukou@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp