Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-33878: Doc: Fix missing case by simplifying.#7762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-33878: Doc: Fix missing case by simplifying.#7762
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The documentation was not covering multiple targets enclosed byparenthesis nor multiple targets enclosed by brackets, adding them allwould be heavy, an else cover them all and is lighter to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like the simplified version. As a side note, I would say that a lot of people find surprising derivatives of
[]= []
Although this is covered inThe object must be iterable with the same number of terms as there are targets in the target list
maybe it would be useful to explicitly list that case.
@pablogsal thanks for the review, something like:
? I'm not a huge fan of explicitly listing this already covered case, the sentences are already complicated, do you think it's worth it? |
pablogsal commentedNov 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@JulienPalard Probably not, let's keep this simple as you suggest :) |
ping to remind that@gvanrossum wanted this PR to be merged. |
Whoa, my desire was for |
Thanks@JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
bedevere-bot commentedNov 11, 2018
GH-10472 is a backport of this pull request to the3.7 branch. |
The documentation was not covering multiple targets enclosed byparenthesis nor multiple targets enclosed by brackets, adding them allwould be heavy, an else cover them all and is lighter to read.(cherry picked from commit082875d)Co-authored-by: Julien Palard <julien@palard.fr>
bedevere-bot commentedNov 11, 2018
GH-10473 is a backport of this pull request to the3.6 branch. |
The documentation was not covering multiple targets enclosed byparenthesis nor multiple targets enclosed by brackets, adding them allwould be heavy, an else cover them all and is lighter to read.(cherry picked from commit082875d)Co-authored-by: Julien Palard <julien@palard.fr>
The documentation was not covering multiple targets enclosed byparenthesis nor multiple targets enclosed by brackets, adding them allwould be heavy, an else cover them all and is lighter to read.(cherry picked from commit082875d)Co-authored-by: Julien Palard <julien@palard.fr>
The documentation was not covering multiple targets enclosed byparenthesis nor multiple targets enclosed by brackets, adding them allwould be heavy, an else cover them all and is lighter to read.(cherry picked from commit082875d)Co-authored-by: Julien Palard <julien@palard.fr>
Uh oh!
There was an error while loading.Please reload this page.
The documentation was not covering multiple targets enclosed by
parenthesis nor multiple targets enclosed by brackets, adding them all
would be heavy, an else cover them all and is lighter to read.
https://bugs.python.org/issue33878