Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-75128: Fix create_server to handle the case when iface isn't IPv6 enabled.#7207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
1st1 wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
from1st1:fix6

Conversation

1st1
Copy link
Member

@1st11st1 commentedMay 29, 2018•
edited by bedevere-appbot
Loading

@1st11st1 requested a review frompitrouMay 29, 2018 15:40
@1st11st1 requested a review fromasvetlov as acode ownerMay 29, 2018 15:40
@1st11st1 changed the titlebpo-30945: Fix create_server to handle the case when iface isn't IPv6…bpo-30945: Fix create_server to handle the case when iface isn't IPv6 enabled.May 29, 2018
@1st1
Copy link
MemberAuthor

Not sure how to test this though.

@1st1
Copy link
MemberAuthor

@pitrou Could you please take a look? Alternatively I can close this PR and you can submit a new one (the patch is yours :))

Copy link
Member

@pitroupitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. I don't think there's an easy way to test this, apart perhaps through mocking.

@1st1
Copy link
MemberAuthor

Looks good to me. I don't think there's an easy way to test this, apart perhaps through mocking.

Thanks. I'll think about adding a mocking test. This won't be merged till after 3.7.0 though.

Copy link
Contributor

@asvetlovasvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelSep 21, 2024
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelDec 15, 2024
@picnixzpicnixz changed the titlebpo-30945: Fix create_server to handle the case when iface isn't IPv6 enabled.gh-75128: Fix create_server to handle the case when iface isn't IPv6 enabled.Dec 15, 2024
@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 27, 2025
@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelApr 9, 2025
@github-actionsGitHub Actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelMay 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@asvetlovasvetlovasvetlov approved these changes

@pitroupitroupitrou approved these changes

Assignees
No one assigned
Labels
DO-NOT-MERGEstaleStale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@1st1@asvetlov@pitrou@iritkatriel@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp