NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-33440: Defer imports in pathlib to reduce its import time.#6820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

agfor wants to merge2 commits intopython:mainfromagfor:pathlib_defer_imports

Closed

bpo-33440: Defer imports in pathlib to reduce its import time.#6820

agfor wants to merge2 commits intopython:mainfromagfor:pathlib_defer_imports

Conversation

Copy link

agfor commentedMay 14, 2018•
edited
Loading

https://bugs.python.org/issue33440

bpo-33440: Defer imports in pathlib to reduce its import time.

45f5e9b

the-knights-who-say-ni added the CLA signed label

May 14, 2018

bedevere-bot added the awaiting review label

May 14, 2018

serhiy-storchaka reviewed

May 14, 2018

View reviewed changes

Lib/pathlib.py Outdated


		defmake_uri(self,path):
		# Under Windows, file URIs use the UTF-8 encoding.
		fromurllib.parseimportquote_from_bytesasurlquote_from_bytes

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What is the reason of the renaming?

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

there is no reason, you are right but this is just a copy. Now he could remove the renaming.

bpo-33440: Remove unneeded import renames.

01d7fd4

matrixise approved these changes

May 14, 2018

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels

May 14, 2018

Copy link

Member

matrixise commentedMay 14, 2018

@serhiy-storchaka I can't merge this PR, if you want to merge it, let's go! ;-)

Copy link

Member

serhiy-storchaka commentedMay 14, 2018

I don't know whether this change is worth merging.

serhiy-storchaka requested a review frompitrou

May 14, 2018 19:52

Copy link

Member

matrixise commentedMay 14, 2018

ok thanks for your feedback@serhiy-storchaka

csabella requested a review fromncoghlan

May 22, 2019 10:19

csabella requested review fromncoghlan andpitrou and removed request forncoghlan andpitrou

February 7, 2020 11:28

pitrou requested changes

Feb 7, 2020

View reviewed changes

Copy link

Member

pitrou left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, it looks like this review took a long delay for a simple change. This looks good to me on the principle but you need to do two things:

merge / rebase your changes on git master
add a NEWS entry for the change (you can useblurb-it orblurb)

Also, would be nice if you posted import benchmark numbers for the change.

bedevere-bot added awaiting changes and removed awaiting core review labels

Feb 7, 2020

Copy link

bedevere-bot commentedFeb 7, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.