NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

bpo-33351: Correct struct packing in _tracemalloc.c#6761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

emmatyping wants to merge3 commits intopython:masterfromemmatyping:clangwin

Closed

bpo-33351: Correct struct packing in _tracemalloc.c#6761

emmatyping wants to merge3 commits intopython:masterfromemmatyping:clangwin

Conversation

Copy link

Member

emmatyping commentedMay 11, 2018•
edited by bedevere-bot
Loading

This is the first of several patches to add clang-cl compatibility to CPython. (Expect more in the coming days).

While it seems MSVC accepts pragma pack/push after the struct tag, clang-cl does not. AFAIK, pragma pack/push usually should go before the tag. This also adds the same packing topointer_t (which was packed on GCC but not MSVC) and fixed the comment for pointer_t.

Also, I wasn't sure if a news entry was needed since this is a small internal patch and I couldn't find guidelines for when a news entry should be provided.

https://bugs.python.org/issue33351