NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-24132: refactor pathlib to allow easy subclassing#6248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ypsah wants to merge1 commit intopython:masterfromypsah:master

Closed

bpo-24132: refactor pathlib to allow easy subclassing#6248

ypsah wants to merge1 commit intopython:masterfromypsah:master

Conversation

Copy link

ypsah commentedMar 26, 2018•
edited
Loading

PurePath andPath are now just variables pointing at the
corresponding classes (resp. PurePosixPath or PureWindowsPath, and
PosixPath or WindowsPath) depending on the platform running the code.

https://bugs.python.org/issue24132

Copy link

the-knights-who-say-ni commentedMar 26, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

the-knights-who-say-ni added the CLA not signed label

Mar 26, 2018

bedevere-bot added the awaiting review label

Mar 26, 2018

ypsah force-pushed themaster branch frome46fed8 to478aa25Compare

March 27, 2018 23:36

bpo-24132: refactor pathlib to allow easy subclassing

2529dad

`PurePath` and `Path` are now just variables pointing at thecorresponding classes (resp. PurePosixPath or PureWindowsPath, andPosixPath or WindowsPath) depending on the platform running the code.

ypsah force-pushed themaster branch from478aa25 to2529dadCompare

March 27, 2018 23:50

brettcannon removed the CLA not signed label

Mar 26, 2019

the-knights-who-say-ni added the CLA not signed label

Mar 26, 2019

Copy link

Member

brettcannon commentedMar 26, 2019

Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR.

brettcannon closed this

Mar 26, 2019

gst reviewed

Mar 26, 2021

View reviewed changes

Lib/pathlib.py

		class_PathParents(Sequence):
		"""This object provides sesquence-like access to the logical ancestors
		of a path. Don't try to construt it yourself."""
		___slots__= ('pathcls','_drv','_root','_parts')