Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-29481: DOC: mark which version typing.Deque added#61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
tacaswell wants to merge1 commit intopython:masterfromtacaswell:doc_deque_vadded

Conversation

tacaswell
Copy link
Contributor

This is targeted at 3.6, but half of it should be backported to 3.5.

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username onbugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, pleasecreate one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign thePSF contributor agreement
  4. If you just signed the CLA, pleasewait at least a day and then check "Your Details" onbugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@tacaswelltacaswell changed the base branch frommaster to3.6February 13, 2017 04:01
@codecov
Copy link

codecovbot commentedFeb 13, 2017•
edited
Loading

Codecov Report

Merging#61 intomaster willincrease coverage by<.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master      #61      +/-   ##==========================================+ Coverage   82.37%   82.37%   +<.01%==========================================  Files        1427     1427                Lines      350948   350948              ==========================================+ Hits       289091   289095       +4+ Misses      61857    61853       -4
Impacted FilesCoverage Δ
Lib/heapq.py96.56% <ø> (-0.77%)❌
Lib/threading.py82.6% <ø> (-0.18%)❌
Lib/test/test_smtplib.py86.71% <ø> (+0.22%)✅
Lib/test/test_strptime.py95.01% <ø> (+0.26%)✅
Lib/_strptime.py95.01% <ø> (+0.33%)✅
Lib/test/test_thread.py66.83% <ø> (+0.51%)✅
Lib/test/test_capi.py92.5% <ø> (+0.55%)✅

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update649a7ca...5dd1ab0. Read thecomment docs.

Copy link
Member

@berkerpeksagberkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I've re-targeted this to master branch. We can then backport this to 3.6. For 3.5, we'll need a separate PR that adds.. versionadded:: 3.5.4.

@@ -574,6 +574,9 @@ The module defines the following classes, functions and decorators:

A generic version of :class:`collections.deque`.

.. versionadded:: 3.5.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For 3.6 docs, we can remove.. versionadded:: 3.5.4.

@berkerpeksagberkerpeksag changed the base branch from3.6 tomasterFebruary 13, 2017 11:26
@tacaswell
Copy link
ContributorAuthor

Should the 3.5 one also target master?

@tacaswell
Copy link
ContributorAuthor

fixed and force-pushed.

I am currently running the CLA by my employer, it may be faster to just have someone else do this (given how minor it is).

@berkerpeksag
Copy link
Member

Should the 3.5 one also target master?

3.5 should be against 3.5 branch, but don't worry about that :) Core developers can do the 3.5 backport.

@tacaswell
Copy link
ContributorAuthor

Closing as this can be fixed faster by others than I expect to be able to sign the CLA.

@tacaswelltacaswell deleted the doc_deque_vadded branchFebruary 15, 2017 13:32
@gvanrossumgvanrossum mentioned this pull requestApr 10, 2022
jaraco pushed a commit that referenced this pull requestDec 2, 2022
jaraco pushed a commit to jaraco/cpython that referenced this pull requestFeb 17, 2023
jaraco pushed a commit to jaraco/cpython that referenced this pull requestFeb 17, 2023
Backport fix for test isolation from Python 3.8/3.7Closespython#61See merge request python-devs/importlib_resources!63
jaraco pushed a commit to jaraco/cpython that referenced this pull requestFeb 17, 2023
isidentical pushed a commit to isidentical/cpython that referenced this pull requestMar 30, 2023
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull requestApr 10, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@berkerpeksagberkerpeksagberkerpeksag requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tacaswell@the-knights-who-say-ni@berkerpeksag
[8]ページ先頭
©2009-2025 Movatter.jp