Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
[2.7] bpo-32997: Fix REDOS in fpformat#5984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
benjaminp merged 3 commits intopython:2.7fromdavisjam:TestAndFixCatastrophicBacktracking_fpformatMar 6, 2018
Merged
[2.7] bpo-32997: Fix REDOS in fpformat#5984
benjaminp merged 3 commits intopython:2.7fromdavisjam:TestAndFixCatastrophicBacktracking_fpformatMar 6, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The regex to decode a number in fpformat is susceptible tocatastrophic backtracking.This is a potential DOS vector if a server is using fpformat onuntrusted number strings.Replace it with an equivalent non-vulnerable regex.The match behavior of the new regex is slightly different.This difference is addressed with a follow-up check.
ContributorAuthor
davisjam commentedMar 5, 2018
@serhiy-storchaka Figured you might be a good reviewer? |
Use a simplified regex.Capture the integer part of the number in one group,then strip off leading 0's.
ContributorAuthor
davisjam commentedMar 5, 2018
@serhiy-storchakafc083d0 addresses your suggestion in the bpo. I agree that this seems like a better approach. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
The regex to decode a number in fpformat is susceptible to
catastrophic backtracking.
This is a potential DOS vector if a server is using fpformat on
untrusted number strings.
Replace it with an equivalent non-vulnerable regex.
The match behavior of the new regex is slightly different.
This difference is addressed with a follow-up check.
https://bugs.python.org/issue32997