Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-32911: Add new AST node for docstring#5927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Some changes are not PEP 7 compliant because I've copied from old code beforeGH-46. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Added few nitpicks, but LGTM in general!
Python/ast.c Outdated
| } | ||
| } | ||
| returnNULL; | ||
| return0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Functions in this file usually return 1 on success and 0 on error (except functions which need to return a non-negative index on success).
| c->u->u_lineno = st->lineno; | ||
| } | ||
| /* Every annotated class and module should have __annotations__. */ | ||
| if (find_ann(stmts)) { | ||
| ADDOP(c, SETUP_ANNOTATIONS); | ||
| } | ||
| if (!asdl_seq_LEN(stmts)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe move this to the bottom of this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be before asdl_seq_GET.
And this code is copied back from 3.6. (There are extra blank line, I'll remove it)
Lines 1457 to 1459 inbaa4507
| if (!asdl_seq_LEN(stmts)) | |
| return1; | |
| st= (stmt_ty)asdl_seq_GET(stmts,0); |
Tools/parser/unparse.py Outdated
| @@ -81,6 +79,10 @@ def _Expr(self, tree): | |||
| self.fill() | |||
| self.dispatch(tree.value) | |||
| def _DocString(self, t): | |||
| self.fill() | |||
| self.write(repr(t.s)) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why notfill()?
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue32911