Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix typo#59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
googya wants to merge1 commit intopython:masterfromgoogya:master
Closed

fix typo#59

googya wants to merge1 commit intopython:masterfromgoogya:master

Conversation

googya
Copy link

fix typo

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username onbugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, pleasecreate one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign thePSF contributor agreement
  4. If you just signed the CLA, pleasewait at least a day and then check "Your Details" onbugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@codecov
Copy link

codecovbot commentedFeb 13, 2017

Codecov Report

Merging#59 intomaster willdecrease coverage by-0.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master      #59      +/-   ##==========================================- Coverage   82.37%   82.37%   -0.01%==========================================  Files        1427     1427                Lines      350948   350948              ==========================================- Hits       289102   289084      -18- Misses      61846    61864      +18

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update61e2bc7...a8d3637. Read thecomment docs.

Copy link
Member

@methanemethane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for fix typos.
But two typos are from upstream project. Please fix them at upstream.
Remained three fixes are LGTM

@@ -100,7 +100,7 @@ dnl Check to see whether a particular set of modules exists. Similar to
dnl PKG_CHECK_MODULES(), but does not set variables or print errors.
dnl
dnl Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG])
dnl only at the firstoccurence in configure.ac, so if the first place
dnl only at the firstoccurrence in configure.ac, so if the first place
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This file is generated. Don't change this file.
This typo comes frompkg.m4 inpkg-config. Please fix it in upstream.

@@ -1638,7 +1638,7 @@ local void fill_window(s)
*
* deflate_stored() is written to minimize the number of times an input byte is
* copied. It is most efficient with large input and output buffers, which
* maximizes theopportunites to have a single copy from next_in to next_out.
* maximizes theopportunities to have a single copy from next_in to next_out.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This file is bundled. Please report the typo to zlib.

quazi-irfan reacted with thumbs up emoji
@googyagoogya closed thisFeb 14, 2017
@gvanrossumgvanrossum mentioned this pull requestApr 10, 2022
jaraco pushed a commit that referenced this pull requestDec 2, 2022
mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull requestMar 27, 2023
oraluben pushed a commit to oraluben/cpython that referenced this pull requestJul 12, 2023
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull requestApr 10, 2025
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@methanemethanemethane requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@googya@the-knights-who-say-ni@methane@berkerpeksag@Mariatta

[8]ページ先頭

©2009-2025 Movatter.jp