NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-32604: Swap threads only if the interpreter is different.#5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ericsnowcurrently merged 2 commits intopython:masterfromericsnowcurrently:fix-thread-swap-same-interpreter

Feb 20, 2018

Merged

bpo-32604: Swap threads only if the interpreter is different.#5778

ericsnowcurrently merged 2 commits intopython:masterfromericsnowcurrently:fix-thread-swap-same-interpreter

Feb 20, 2018

Conversation

Copy link

Member

ericsnowcurrently commentedFeb 20, 2018•
edited by bedevere-bot
Loading

The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same.

https://bugs.python.org/issue32604

ericsnowcurrently added2 commits

February 20, 2018 17:14

Add tests that ensure we properly handle restoring in same interpreter.

3455570

Swap threads only if the interpreter is different.

e1d0383

ericsnowcurrently added the skip news label

Feb 20, 2018

the-knights-who-say-ni added the CLA signed label

Feb 20, 2018

bedevere-bot added the awaiting merge label

Feb 20, 2018

ericsnowcurrently added needs backport to 3.7 awaiting merge and removed awaiting merge labels

Feb 20, 2018

ericsnowcurrently merged commitf53d9f2 intopython:master

Feb 20, 2018

Copy link

Contributor

miss-islington commentedFeb 20, 2018

Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

bedevere-bot removed the awaiting merge label

Feb 20, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Feb 20, 2018

bpo-32604: Swap threads only if the interpreter is different. (python…

2f3f233

…gh-5778)The CPython runtime assumes that there is a one-to-one relationship (for a given interpreter) between PyThreadState and OS threads. Sending and receiving on a channel in the same interpreter was causing crashes because of this (specifically due to a check in PyThreadState_Swap()). The solution is to not switch threads if the interpreter is the same.(cherry picked from commitf53d9f2)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>