Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-32604: Clean up created subinterpreters before runtime finalization.#5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 2 commits intopython:masterfromericsnowcurrently:interpreter-id-refcountFeb 17, 2018
Merged
bpo-32604: Clean up created subinterpreters before runtime finalization.#5709
ericsnowcurrently merged 2 commits intopython:masterfromericsnowcurrently:interpreter-id-refcountFeb 17, 2018
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Thanks@ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
bedevere-bot commentedFeb 17, 2018
GH-5710 is a backport of this pull request to the3.7 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 17, 2018
…on. (pythongh-5709)(cherry picked from commit4c6955e)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
CPython crashes during finalization if any subinterpreters haven't been destroyed. From the perspective of the C-API this is reasonable. However, for Python bindings to that C-API, it is not. This patch fixes that by destroying any interpreter for which the Python-level ID object is garbage-collected.
https://bugs.python.org/issue32604