Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
bpo-29176: Fix name of the _curses.window class#52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Set name to "_curses.window" instead of "_curses.curses window" (witha space!?).
Codecov Report
@@ Coverage Diff @@## master #52 +/- ##==========================================+ Coverage 82.37% 82.37% +<.01%========================================== Files 1427 1427 Lines 350948 350948 ==========================================+ Hits 289093 289098 +5+ Misses 61855 61850 -5 Continue to review full report at Codecov.
|
briancurtin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1, trivial change
briancurtin left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
+1, trivial change (actually approving now)
vstinner commentedFeb 12, 2017
Serhiy Storshaka asked me if the change can have any impact on pickle. No, it doesn't because these objects were not picklable before and are not pickable after ;-) |
Set name to "_curses.window" instead of "_curses.curses window" (witha space!?).(cherry picked from commit61e2bc7)
Backport bpo-33254 - contents() returns an IterableClosespython#52See merge request python-devs/importlib_resources!57
Co-authored-by: Ken Jin <28750310+Fidget-Spinner@users.noreply.github.com>Co-authored-by: Brandt Bucher <brandt@python.org>
Set name to "_curses.window" instead of "_curses.curses window" (with
a space!?).