Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
[backport to 3.5] bpo-27122: Fix comment to point to correct issue number (#47)#50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
It took me quite a bit to figure out what this was referring to,since the given issue number is wrong, and the original commitmessage I found through git blame lists a different, also wrongissue number... seehttps://bugs.python.org/issue27122#msg279449(cherry picked from commitaf88e7e)
Codecov Report
@@ Coverage Diff @@## 3.5 #50 +/- ##====================================== Coverage ? 82.37% ====================================== Files ? 1427 Lines ? 350948 Branches ? 0 ====================================== Hits ? 289099 Misses ? 61849 Partials ? 0
Continue to review full report at Codecov.
|
Mariatta approved these changesFeb 12, 2017
Thanks for the approvals, Mariatta. GitHub overwrote the original author's name again:c6d2f49 |
Mr3x33 added a commit to Mr3x33/cpython that referenced this pull requestSep 17, 2021
colesbury referenced this pull request in colesbury/nogilOct 6, 2021
Once the threads object queue is empty, other threads may explicitlymerge reference counts immediately. It's no longer safe for the originalthread to do RC operations because of races with accesses to ob_ref_local.This ensures that the queue is empty when it's removed from the hashtablemapping thread-id to queue. There are still other RC operations that canhappen during thread destruction, so the call to _Py_queue_destroy willprobably need to be moved.See#50
colesbury referenced this pull request in colesbury/nogilOct 6, 2021
A partially initialized thread may have an entry in the interpreterwithout a corresponding entry in the biased-refcounting hashtable.See#50
jaraco pushed a commit that referenced this pull requestDec 2, 2022
Now reads: `The PR then needs to be backported manually.`
jaraco added a commit to jaraco/cpython that referenced this pull requestFeb 17, 2023
* Added a config for dependabot.* Update features list for dependabot.Co-authored-by: KOLANICH <kolan_n@mail.ru>
mgmacias95 pushed a commit to mgmacias95/cpython that referenced this pull requestMar 24, 2023
This was referencedFeb 11, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me quite a bit to figure out what this was referring to,
since the given issue number is wrong, and the original commit
message I found through git blame lists a different, also wrong
issue number... seehttps://bugs.python.org/issue27122#msg279449
(cherry picked from commitaf88e7e)