Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-13553: Document tkinter.Tk args#4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 8 commits intopython:mainfromcsabella:bpo13553
May 10, 2022

Conversation

csabella
Copy link
Contributor

@csabellacsabella commentedDec 11, 2017•
edited by bedevere-bot
Loading

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@terryjreedy
Copy link
Member

terryjreedy commentedDec 12, 2017•
edited
Loading

None of my comments are outdated by applying Serhiy's suggestions. My review just happened to start before the patch arrived, and except for 1, happen to be attached to the same sentences. Serhiy, please also review my comments.

Specifies that the main window for the application is to be embedded in
the window whose identifier is given, instead of being created as an
independent toplevel window.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

While we are documenting the Tk class. Would it be worth it to document Tk attributes? master, children and tk.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The current page reads more like a 'getting started' or 'how to', so I wasn't sure how much detail to add. I know there's a separate bug issue where Terry figured out the difference between master and parent, so maybe it would be worthwhile to include that here?

@csabella
Copy link
ContributorAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@csabella
Copy link
ContributorAuthor

@terryjreedy@serhiy-storchaka@vstinner
I've made additional changes to document the attributes and to remove the documentation of readprofile. Thanks!

terryjreedy
terryjreedy previously approved these changesFeb 2, 2018
@vstinner
Copy link
Member

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted):https://devguide.python.org/#status-of-python-branches

@JulienPalard
Copy link
Member

@csabella Looks like this PR is almost OK, maybe just missing the mention thatclassName permits to choose the title of the window (last message of Mark). I tried to mark as resolved every actually resolved comments, I'll let you read the rest of them a last time.

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, it seems the remaining comments don't need to be blocking.

@JelleZijlstraJelleZijlstra self-assigned thisMay 8, 2022
@JelleZijlstraJelleZijlstra added needs backport to 3.9only security fixes needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsMay 8, 2022
@JelleZijlstra
Copy link
Member

Planning to merge this unless someone has further comments.

@taleinat
Copy link
Contributor

LGTM

@JelleZijlstraJelleZijlstra merged commitc56e2bb intopython:mainMay 10, 2022
@miss-islington
Copy link
Contributor

Thanks@csabella for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot
Copy link

GH-92593 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed needs backport to 3.11only security fixes needs backport to 3.10only security fixes labelsMay 10, 2022
@bedevere-bot
Copy link

GH-92594 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelMay 10, 2022
@bedevere-bot
Copy link

GH-92595 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull requestMay 10, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
(cherry picked from commitc56e2bb)Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@vadmiumvadmiumvadmium left review comments

@rosemanrosemanroseman left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

@JulienPalardJulienPalardJulienPalard approved these changes

@taleinattaleinattaleinat approved these changes

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@terryjreedyterryjreedyterryjreedy left review comments

Assignees

@JelleZijlstraJelleZijlstra

Labels
docsDocumentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

13 participants
@csabella@bedevere-bot@terryjreedy@ned-deily@roseman@vstinner@JulienPalard@JelleZijlstra@taleinat@miss-islington@vadmium@serhiy-storchaka@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp