Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-27122: Fix comment to point to correct issue ##47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
berkerpeksag merged 1 commit intopython:masterfromnjsmith:njsmith-patch-1
Feb 12, 2017

Conversation

njsmith
Copy link
Contributor

It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... seehttps://bugs.python.org/issue27122#msg279449

Here's the correct issue link to confirm:https://bugs.python.org/issue27122

deronnax reacted with thumbs up emoji
It took me quite a bit to figure out what this was referring to, since the given issue number is wrong, and the original commit message I found through git blame lists a different, also wrong issue number... seehttps://bugs.python.org/issue27122#msg279449
@codecov
Copy link

codecovbot commentedFeb 12, 2017

Codecov Report

Merging#47 intomaster willdecrease coverage by-0.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master      #47      +/-   ##==========================================- Coverage   82.37%   82.37%   -0.01%==========================================  Files        1427     1427                Lines      350948   350948              ==========================================- Hits       289089   289083       -6- Misses      61859    61865       +6

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update2294f3a...a4f3401. Read thecomment docs.

@berkerpeksagberkerpeksag merged commitaf88e7e intopython:masterFeb 12, 2017
berkerpeksag pushed a commit that referenced this pull requestFeb 12, 2017
It took me quite a bit to figure out what this was referring to,since the given issue number is wrong, and the original commitmessage I found through git blame lists a different, also wrongissue number... seehttps://bugs.python.org/issue27122#msg279449(cherry picked from commitaf88e7e)
berkerpeksag pushed a commit that referenced this pull requestFeb 12, 2017
It took me quite a bit to figure out what this was referring to,since the given issue number is wrong, and the original commitmessage I found through git blame lists a different, also wrongissue number... seehttps://bugs.python.org/issue27122#msg279449(cherry picked from commitaf88e7e)
@berkerpeksag
Copy link
Member

Thanks! I've created#48 and#50 to backport this to maintenance branches.

@MariattaMariatta changed the titleFix comment to point to correct issue #bpo-27122: Fix comment to point to correct issue #Feb 13, 2017
iritkatriel referenced this pull request in iritkatriel/cpythonJul 23, 2021
jaraco pushed a commit that referenced this pull requestDec 2, 2022
oraluben pushed a commit to oraluben/cpython that referenced this pull requestJun 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@berkerpeksagberkerpeksagberkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@njsmith@berkerpeksag@Mariatta@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp