NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

bpo-32126: Skip asyncio test when sem_open() is not functional#4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

xdegaye merged 2 commits intopython:masterfromxdegaye:bpo-32126

Nov 26, 2017

Merged

bpo-32126: Skip asyncio test when sem_open() is not functional#4559

xdegaye merged 2 commits intopython:masterfromxdegaye:bpo-32126

Nov 26, 2017

Conversation

Copy link

Contributor

xdegaye commentedNov 25, 2017•
edited by bedevere-bot
Loading

https://bugs.python.org/issue32126

bpo-32126: Skip asyncio test when sem_open() is not functional

96a6cbc

xdegaye added topic-asyncio testsTests in the Lib/test dir labels

Nov 25, 2017

xdegaye requested a review from1st1

November 25, 2017 10:56

the-knights-who-say-ni added the CLA signed label

Nov 25, 2017

bedevere-bot added the awaiting merge label

Nov 25, 2017

asvetlov reviewed

Nov 25, 2017

View reviewed changes

Lib/test/test_asyncio/test_events.py


		deftest_get_event_loop_new_process(self):
		# Skip the test if the sem_open() implementation is broken.
		support.import_module('multiprocessing.synchronize')

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The check is very non-obvious.
Don't how to make it more verbose and explicit.
If it's impossible -- I can live with it.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TheProcessPoolExecutor uses themultiprocessing (mp) module. Themp module is not functional when themp.synchronize module cannot be imported and all themp tests are skipped in that case. So we use here the same idiom used to skip themp tests (i.e.test.support.import_module('multiprocessing.synchronize')) to skip this test when the platformsem_open implementation is broken or missing.

What about replacing the comment with:

Issue bpo-32126: The multiprocessing module used by ProcessPoolExecutoris not functional when the multiprocessing.synchronize module cannot be imported.