Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[backport to 2.7] Change documentation'sShow Source link to GitHub#44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Mariatta merged 2 commits intopython:2.7fromMariatta:bpo-news-support-2.7
Feb 12, 2017

Conversation

Mariatta
Copy link
Member

@MariattaMariatta commentedFeb 12, 2017
edited
Loading

Change documentation'sShow Source link to GitHub (2.7 branch)
Render issue role as bpo-NNNN

Change the url to 2.7(cherry picked from commit79ab8be)
@@ -58,7 +58,7 @@ def new_depart_literal_block(self, node):

def issue_role(typ, rawtext, text, lineno, inliner, options={}, content=[]):
issue = utils.unescape(text)
text = 'issue ' + issue
text = 'bpo- ' + issue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there space between 'bpo-' and issue number?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No, there shouldn't be a space 😅
Thanks for the review :) Will fix soon.

@methane
Copy link
Member

Hm, the title of pull request is bit misleading. doc of Python 2.7 doesn't include Misc/NEWS.
But this pull request backports these changes.

  • Change link target of "Source code:" from hg.python.org to github
  • issue role (:issue:`1234`) rendered as "bpo-1234" instead of "issue 1234" (example)

Copy link
Member

@methanemethane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I didmake html in local, and it works as expected.
LGTM.

@MariattaMariatta changed the title[backport to 2.7] Support "bpo-" in Misc/NEWS[backport to 2.7] Change documentation'sShow Source link to GitHubFeb 12, 2017
@Mariatta
Copy link
MemberAuthor

Thanks@methane :) I updated the pull request description.
What do you think?

@methane
Copy link
Member

LGTM

@MariattaMariatta merged commit52b8c55 intopython:2.7Feb 12, 2017
@MariattaMariatta deleted the bpo-news-support-2.7 branchFebruary 12, 2017 20:59
gnprice added a commit to gnprice/cpython that referenced this pull requestAug 15, 2019
The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/#ModificationsChange the link to one that points to the current version.
benjaminp pushed a commit that referenced this pull requestSep 9, 2019
)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/#ModificationsChange the link to one that points to the current version. Also, use HTTPS.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2019
pythonGH-15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS.(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 9, 2019
pythonGH-15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS.(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
benjaminp pushed a commit that referenced this pull requestSep 9, 2019
GH-15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS..(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
benjaminp added a commit that referenced this pull requestSep 9, 2019
GH-15808)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS..(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull requestSep 9, 2019
…15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS.(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
miss-islington added a commit that referenced this pull requestSep 9, 2019
…15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/GH-ModificationsChange the link to one that points to the current version. Also, use HTTPS.(cherry picked from commit64c6ac7)Co-authored-by: Greg Price <gnprice@gmail.com>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull requestJul 20, 2020
…ythonGH-15301)The link we have points to the version from Unicode 6.0.0, dated 2010.There have been numerous updates to it since then:https://www.unicode.org/reports/tr44/#ModificationsChange the link to one that points to the current version. Also, use HTTPS.
jaraco pushed a commit to jaraco/cpython that referenced this pull requestFeb 17, 2023
Fix `contents()` so that it no longer returns unrelated itemsClosespython#44See merge request python-devs/importlib_resources!48
oraluben pushed a commit to oraluben/cpython that referenced this pull requestJun 26, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@methanemethanemethane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Mariatta@methane@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp