NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.8k

bpo-11063: Create _uuid1 submodule#3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

vstinner wants to merge3 commits intopython:masterfromvstinner:uuid1

Closed

bpo-11063: Create _uuid1 submodule#3795

vstinner wants to merge3 commits intopython:masterfromvstinner:uuid1

Conversation

Copy link

Member

vstinner commentedSep 28, 2017•
edited by bedevere-bot
Loading

uuid module: move getnode() and uuid1() implementations to a new
_uuid1 submodule which is now loaded on demand to reduce side effects
on "import uuid".

https://bugs.python.org/issue11063

bpo-11063: Create _uuid1 submodule

6a1eb67

uuid module: move getnode() and uuid1() implementations to a new_uuid1 submodule which is now loaded on demand to reduce side effectson "import uuid".

the-knights-who-say-ni added the CLA signed label

Sep 28, 2017

bedevere-bot added the awaiting merge label

Sep 28, 2017

Copy link

MemberAuthor

vstinner commentedSep 28, 2017

_unixdll_getnode() and _windll_getnode() functions used UUID(bytes=bytes).node to convert bytes to a UUID object, then to get the node. I added a new "def _bytes_to_node(rawbytes):" helper function to break the dependency from _uuid1 to the uuid.UUID class. IMHO _bytes_to_node() is simple enough to justify the "duplication" of the code.

vstinner added2 commits

September 28, 2017 12:27

Add empty lines for PEP 8 and readability

18cb85b

Move getnode() cache back to uui.py

228b8a3

Move also "import sys" at _uuid1.py top level.

methane mentioned this pull request

Sep 28, 2017

bpo-5885: fix slow uuid initialization#3684

Closed

Copy link

Contributor

gronke commentedSep 28, 2017

@Haypo have you noticed#3684 ? You're addressing a similar problem and your comment's are welcome! Personally I don't see a benefit from breaking uuid in two separate files. Instead we could move all code paths involved in uuid1() together. I'll comment on the other PR why we didn't.