Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
bpo-27494: Fix 2to3 handling of trailing comma after a generator expression#3771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…essionWhile this is a valid Python 2 and Python 3 syntax lib2to3 would chokeon it: set(x for x in [],)This patch changes the grammar definition used by lib2to3 so that theactual Python syntax is supported now and backwards compatibility ispreserved.
@ambv or@benjaminp may I ask for a review? If there's a more appropriate review I'd appreciate an information. |
Thanks! |
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull requestJul 11, 2018
… generator expression (python#3771)"This reverts commitaf810b3.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJul 31, 2018
… generator expression (pythonGH-3771)" (pythonGH-8241)This reverts commitaf810b3.This is not valid syntax (see bpo-32012).(cherry picked from commit4b8a7f5)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While this is a valid Python 2 and Python 3 syntax lib2to3 would choke
on it:
This patch changes the grammar definition used by lib2to3 so that the
actual Python syntax is supported now and backwards compatibility is
preserved.
https://bugs.python.org/issue27494
Note: there are some issues with the build of the first pull request I created (#60) to merge this change so this is a replacement pull request I create, hoping it'll fix things.