Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username onbugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

user@freebsd11 /tmp/test % ls -al           total 9drwxr-xr-x   2 fnord  wheel   2 Sep 21 11:14 .drwxrwxrwt  14 root   wheel  23 Sep 21 11:09 ..user@freebsd11 /tmp/test % /usr/bin/time -l python3.6 -c "import uuid"        1.96 real         0.48 user         1.47 sys     17540  maximum resident set size         4  average shared memory size         4  average unshared data size       128  average unshared stack size      4331  page reclaims         0  page faults         0  swaps        12  block input operations         1  block output operations         0  messages sent         0  messages received         0  signals received        33  voluntary context switches        22  involuntary context switchesuser@freebsd11 /tmp/test % fetch https://raw.githubusercontent.com/igalic/cpython/730040ee331f50f666b6109d5ed9545e9df00bea/Lib/uuid.pyuuid.py                                       100% of   24 kB 2882 kBps 00m00suser@freebsd11 /tmp/test % /usr/bin/time -l python3.6 -c "import uuid"                                                                        0.04 real         0.02 user         0.02 sys      8496  maximum resident set size         4  average shared memory size         4  average unshared data size       128  average unshared stack size      1342  page reclaims         0  page faults         0  swaps         4  block input operations         1  block output operations         0  messages sent         0  messages received         0  signals received         2  voluntary context switches         1  involuntary context switchesuser@freebsd11 /tmp/test % sysctl hw.model hw.machine hw.ncpuhw.model: Intel(R) Xeon(R) CPU E5-2630 v3 @ 2.40GHzhw.machine: amd64hw.ncpu: 32

https://asciinema.org/a/UG8xwIPSME3HB8Y5LTERT6mPC

@the-knights-who-say-ni the CLA is signed by@igalic and me.

added a NEWS entry now too

can someone please explain why the news check is failing?
(i've now regenerated it withblurb add)

I wanted to compare the performance impact duplicating the ctypes imports:

importtimeimportctypesimportctypes.utildefmeasure(cb,iterations):start=time.time()foriinrange(iterations):cb()end=time.time()return (end-start)defdo():importctypesimportctypes.utildefdont():passdefrun(iterations):print("Iterations:",iterations)print("A",measure(do,iterations))print("B",measure(dont,iterations))run(1000000)run(100000000)

# python3.6 measure-import-time.pyIterations: 1000000A 0.5856528282165527B 0.08484673500061035Iterations: 100000000A 58.5674729347229B 8.484308242797852

Is this something we should optimize for?

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI didn't expect the Spanish Inquisition!. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes,you will be put in the comfy chair!

@merwok your requested changes were addressed / commented. Thanks for the review!

I didn't expect the Spanish Inquisition!

Nobody expects the Spanish Inquisition!

@merwok: please review the changes made to this pull request.

Alright I started a build on custom buildbots:http://buildbot.python.org/all/waterfall?category=custom.stable&category=custom.unstable

I don’t feel qualified to merge this; maybe@methane would like to take it?

Tests are failed on Windows:http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20custom/builds/20/steps/test/logs/stdio

======================================================================ERROR: test_windll_getnode (test.test_uuid.TestInternals)----------------------------------------------------------------------Traceback (most recent call last):  File "C:\buildbot.python.org\custom.kloth-win64\build\lib\test\test_uuid.py", line 552, in test_windll_getnode    node = uuid._windll_getnode()  File "C:\buildbot.python.org\custom.kloth-win64\build\lib\uuid.py", line 573, in _windll_getnode    if _UuidCreate(_buffer) == 0:TypeError: 'NoneType' object is not callable----------------------------------------------------------------------

Whyimport ctypes was moved into functions? This is contrary PEP 8.

That’s why I pinged Inada-san: there was a recent python-dev discussion about improving startup times, with the pros and cons of function-level imports.

Why import ctypes was moved into functions? This is contrary PEP 8.

The import was in a try/except block and I thought it was more elegant to let theexisting exception handling do the job. I didtest the performance impact of importing ctypes multiple times on a system that successfully imported it once before - results may vary when no ctypes package is available. After thinking about it again, I'd now rather load it once when importing uuid and directly set_no_uuid_generate_time_lookup in case the import fails. That should be quick enough and not have an impact on the runtime performance.

Tests are failed on Windows

Working on it. Downloading Visual Studio

@serhiy-storchaka I've fixed the Windows problem in the commit that caused it and moved the imports to the module level in a separate one. I had to move the code a bit so that the import works for the whole module.

@serhiy-storchaka are there any changes required or can theawaiting changes label be removed?

Is this PR relating tobpo-5885? It is "execution time", not about "import time".

Anyway,#3795 (split uuid1 only code into_uuid1.py) seems more clean.

@methane so you're suggesting to break the code path foruuid1() to a separate file? Personally
I would not prefer to break code in multiple files, but we can group uuid1 related code together by moving it further to the end of the file.

So this PR aims to fix a bug. Since the uuid code is used across various versions of Python, the choice was to fix it with small changes.

Would you discuss onhttps://bugs.python.org/issue11063 ?
I don't have strong opinion and both pull requests seems OK.

I suggest to close this PR in favor of@pitrou's PR#3796 which is more complete (add new tests, add a C extension module).

@pitrou already proposed the same thing inbpo-11063: "PR#3684 seems mostly a subset of what I'm proposing."
https://bugs.python.org/issue11063#msg303230

👍

I close this PR. Let's focus reviews on@pitrou's PR#3796.