NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

Fix syntax error in .mention-bot#361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

dstufft merged 1 commit intomasterfromberkerpeksag-patch-1

Mar 1, 2017

Merged

Fix syntax error in .mention-bot#361

dstufft merged 1 commit intomasterfromberkerpeksag-patch-1

Mar 1, 2017

Conversation

Copy link

Member

berkerpeksag commentedMar 1, 2017

No description provided.

Fix syntax error in .mention-bot

188001a

the-knights-who-say-ni added the CLA signed label

Mar 1, 2017

alex approved these changes

Mar 1, 2017

View reviewed changes

berkerpeksag mentioned this pull request

Mar 1, 2017

Fix syntax error in .mention-bot#362

Closed

Copy link

Member

dstufft commentedMar 1, 2017

I am only slightly a moron. Thanks@berkerpeksag!

dstufft approved these changes

Mar 1, 2017

View reviewed changes

Copy link

MemberAuthor

berkerpeksag commentedMar 1, 2017

I don't know why, buthttps://travis-ci.org/python/cpython/requests marked this as "Job rejected". It's 4 am here so I will take a look at Travis later today :)

Copy link

Member

@berkerpeksag that's jsut for the branch itself. When you create a branch in the python/cpython repo it sends a webhook to Travis to have Travis run tests, then when you send a PR it does it again. To reduce he need to run the tests twice, we have travis configured to reject test runs for any branches exceptmaster orX.Y. The PR is still going to get tested.