Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-17446: Get line numbers of properties in doctest#3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mscuthbert wants to merge7 commits intopython:mainfrommscuthbert:fix-issue-17446
Closed

bpo-17446: Get line numbers of properties in doctest#3419

mscuthbert wants to merge7 commits intopython:mainfrommscuthbert:fix-issue-17446

Conversation

@mscuthbert
Copy link

@mscuthbertmscuthbert commentedSep 7, 2017•
edited by serhiy-storchaka
Loading

Doctests currently don’t know the line numbers of tests of properties. Fixes error messages on doctest failures for properties.

https://bugs.python.org/issue17446

#61648

@mscuthbert
Copy link
Author

Hoping that someone might be willing to take time out of their busy schedule to review this -- it already had reviews from the prior bugs-python discussion.@serhiy-storchaka you gave me a fantastic review with great comments on the wave-pathlib request, do you have time or know someone who has time to review this? For those of us using@property and PyDev, having line-numbers (which get hyperlinked to the appropriate code) would be a great time-saver.

@serhiy-storchaka
Copy link
Member

The test is passed if revert changes inLib/doctest.py. Therefore it doesn't test the changed behavior. Could you provide a test that is passed with the patched code and failed with the unpatched code?

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 21, 2022
@AA-Turner
Copy link
Member

Reopening per#61648 (comment)

A

@AA-TurnerAA-Turner reopened thisJun 7, 2022
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelJul 1, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelAug 13, 2022
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelDec 15, 2023
@serhiy-storchaka
Copy link
Member

The test is passed because it testslineno attributes ofExample instances instead ofDocTest instances. Also, the code can be much simpler.

I created an alternative PR#113161.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaAwaiting requested review from serhiy-storchaka

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mscuthbert@serhiy-storchaka@AA-Turner@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp