Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
bpo-47120: make POP_JUMP_IF_NONE/NOT_NONE relative#32359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
iritkatriel commentedApr 6, 2022
The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging). |
Misc/NEWS.d/next/Core and Builtins/2022-04-06-22-50-31.bpo-47120.mbfHs5.rst OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
markshannon commentedApr 7, 2022
The |
markshannon commentedApr 7, 2022
Which means the forwards jumps can be made simpler |
iritkatriel commentedApr 7, 2022
I fixed it now, it was the usual +-1 business. I'll make a separate PR for that, it will be easier to review that way. We can merge magic number later. |
markshannon left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
iritkatriel commentedApr 8, 2022
This will be merged as part of#32400 |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue47120