Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-47120: make POP_JUMP_IF_NONE/NOT_NONE relative#32359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
iritkatriel wants to merge6 commits intopython:mainfromiritkatriel:jump_if

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedApr 6, 2022
edited by bedevere-bot
Loading

@iritkatriel
Copy link
MemberAuthor

The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging).

@markshannon
Copy link
Member

TheFORWARD jumps don't need to includeCHECK_EVAL_BREAKER(), so I think you'll need to implement each instruction independently and not useJUMP_TO_INSTRUCTION.

@markshannon
Copy link
Member

Which means the forwards jumps can be made simpler

TARGET(POP_JUMP_FORWARD_IF_NOT_NONE) {    PyObject *value = POP();    if (value != Py_None) {        JUMPBY(oparg);    }    Py_DECREF(value);    DISPATCH();}

@iritkatriel
Copy link
MemberAuthor

The case of POP_JUMP_IF_TRUE/IF_FALSE is more complicated because of the COMPARE_OP specialisations. I suggest we do it separately (my current patch doesn't work unless I turn off specialization, debugging).

I fixed it now, it was the usual +-1 business. I'll make a separate PR for that, it will be easier to review that way. We can merge magic number later.

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

@iritkatriel
Copy link
MemberAuthor

This will be merged as part of#32400

@iritkatrieliritkatriel deleted the jump_if branchMay 20, 2022 11:18
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@markshannonmarkshannonmarkshannon approved these changes

@brandtbucherbrandtbucherAwaiting requested review from brandtbucher

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iritkatriel@markshannon@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp