Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-62824: add alias for iso-8859-8-i and -e to iso_8859_8#32279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

ringof
Copy link
Contributor

@ringofringof commentedApr 3, 2022•
edited by bedevere-bot
Loading

Add aliases for iso-8859-8-i and iso-8859-8-e, which is the same as iso-8859-8

Co-authored-by: Ben Galin (bensws)
Source for this PR is derived from a patch submitted by bensws:
https://bugs.python.org/file35736/8859-8_aliases_and_test.patch

https://bugs.python.org/issue18624

Copy link
Contributor

@MaxwellDupreMaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ran 266 tests in 4.734s
OK (skipped=13)
Looks ok.

@arhadthedevarhadthedev added the type-featureA feature request or enhancement labelFeb 13, 2023
@arhadthedevarhadthedev changed the titlebpo-18624: add alias for iso-8859-8-i and -e to iso_8859_8gh-62824: add alias for iso-8859-8-i and -e to iso_8859_8Feb 13, 2023
@arhadthedev
Copy link
Member

@malemburg (as an encodings expert)

@basbloemsaat
Copy link
Contributor

Will this PR be accepted? Why is it still open?

@malemburg
Copy link
Member

Yes, I'd accept the PR, but before doing so, the conflicts will have to be resolved and the tests need to finish without errors.

@ambv
Copy link
Contributor

ambv commentedMay 20, 2025•
edited
Loading

Closing in favor of#134306.

@ringof
Copy link
ContributorAuthor

Will this PR be accepted? Why is it still open?

Looks like you get quick results your way!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@MaxwellDupreMaxwellDupreMaxwellDupre approved these changes

@Wulian233Wulian233Wulian233 approved these changes

Assignees
No one assigned
Labels
awaiting core reviewtype-featureA feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10 participants
@ringof@arhadthedev@basbloemsaat@malemburg@ambv@MaxwellDupre@Wulian233@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp