Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure#32223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
-_validate_inner(SRE_CODE *code, SRE_CODE *end, Py_ssize_t groups)+_validate_inner(SRE_CODE *code, SRE_CODE *end, PatternObject *self)
Member
serhiy-storchaka commentedApr 1, 2022
My internet connection is very bad last days, so it will take a time for review, sorry. |
Author
ghost commentedApr 1, 2022
It doesn't matter. |
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
@serhiy-storchaka , please review the commits one by one.
MSVC 2022 non-PGO release build, run
test_re.py. It's a bit slower.But when switching REPEAT very frequently, it has some speed up:
https://bugs.python.org/issue23689