Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-47120: make JUMP_NO_INTERRUPT relative#32221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 10 commits intopython:mainfromiritkatriel:jump_no_interrupt
Apr 5, 2022

Conversation

@iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedMar 31, 2022•
edited
Loading

Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice. These are always tiny jumps too.

@markshannon
Copy link
Member

markshannon commentedApr 1, 2022•
edited
Loading

This would be more robust, if you handled it the same way asJUMP_FORWARD/JUMP_BACKWARD.
Add aJUMP_NO_INTERRUPT virtual instruction, and let the assembler emit the correct opcode.
JUMP_NO_INTERRUPT forward is justJUMP_FORWARD.

iritkatriel reacted with thumbs up emoji

@iritkatriel
Copy link
MemberAuthor

This would be more robust, if you handled it the same way asJUMP_FORWARD/JUMP_BACKWARD. Add aJUMP_NO_INTERRUPT virtual instruction, and let the assembler emit the correct opcode.JUMP_NO_INTERRUPT forward is justJUMP_FORWARD.

Agreed. I'll update this PR after we've merged#32200 because it would clash otherwise.

@iritkatrieliritkatriel changed the titlebpo-47120: replace JUMP_NO_INTERRUPT by the relative JUMP_BACKWARD_NO_INTERRUPTbpo-47120: make JUMP_NO_INTERRUPT relativeApr 2, 2022
@markshannon
Copy link
Member

Looks good.
Feel free to share the new magic number with#32309. One magic number per day should be enough.

@markshannon
Copy link
Member

@iritkatriel I've leave it up to you to merge this and#32309 in whichever order you prefer

iritkatriel reacted with thumbs up emoji

@iritkatrieliritkatriel merged commit0aa8d5c intopython:mainApr 5, 2022
@iritkatrieliritkatriel deleted the jump_no_interrupt branchMay 20, 2022 11:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

+1 more reviewer

@raghavthind2005raghavthind2005raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel@markshannon@brandtbucher@raghavthind2005@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp