Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-90872: Handle negative timeouts for wait on Windows#32079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
Did you want to create an issue to fix |
I was thinking to the DWORD converter change as a separate PR that would not be a candidate for backport. While The change of negative values to exceptions, while probably not relied upon, would be a breaking change for a dot release. Being limited to a new release (3.11) would be easier to reason about downstream rather than a "random" bugfix release (say, 3.9.12). IMO. |
Please add tests and a NEWS entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
How difficult is to write tests?
Tests can spawn a child process that exits after a few seconds. With this PR, a timeout that's larger than4294967.295 should raise |
Uh oh!
There was an error while loading.Please reload this page.
Update Windows wait timeout handling to match the behavior for POSIX. This PR also catches overly values that would conflict with the INFINITE timeout value used in
_winapi.WaitForSingleObject
.These changes should be backported to the maintenance branches.
https://bugs.python.org/issue46716