Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.3k
bpo-42658: Using LCMapStringEx in ntpath.normcase#32010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes from1 commit
060cd71
6ecbc48
c1429b9
81be381
6108d20
3b4a5cb
ef66941
6c0366b
6c6f2e2
15749b8
7b2c62c
a89adc0
4119cc2
8a63de2
6789cd9
d430371
7e0dcf8
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1705,7 +1705,11 @@ def test_no_memleak(self): | ||
blocks = int(match.group(2)) | ||
with self.subTest(frozen_modules=flag, stmt=stmt): | ||
self.assertEqual(refs, 0, out) | ||
if not MS_WINDOWS: | ||
self.assertEqual(blocks, 0, out) | ||
else: | ||
# bpo-42658: on Windows, Python still leaks 1 memory block at exit | ||
self.assertEqual(blocks, 1, out) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Found that there is a block leak here, but I think this is not related to this issue (and have no idea how to fix it 😥). Just skipped it for now, but don't know if it's appropriate to do so. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. It's not appropriate. If it only occurs in this PR, then we need to count references carefully and find out where it's leaking. If it happens in others as well, then we should make sure someone's looking into it and can probably merge anyway. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Got it. | ||
class StdPrinterTests(EmbeddingTestsMixin, unittest.TestCase): | ||