Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-91214: Skip tests failing on Solaris#31978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
kulikjak wants to merge3 commits intopython:main
base:main
Choose a base branch
Loading
fromkulikjak:Solaris-buildbot-green

Conversation

kulikjak
Copy link
Contributor

@kulikjakkulikjak commentedMar 18, 2022•
edited by bedevere-appbot
Loading

This PR should take Solaris worker closer to being green.

https://bugs.python.org/issue47058

@bedevere-botbedevere-bot added the testsTests in the Lib/test dir labelMar 18, 2022
@kulikjakkulikjak changed the titlebpo-47058: Skip tests failing on Solaris workerbpo-47058: Skip tests failing on SolarisMar 18, 2022
@@ -3394,7 +3395,7 @@ def testCMSG_SPACE(self):
# Test CMSG_SPACE() with various valid and invalid values,
# checking the assumptions used by sendmsg().
toobig = self.socklen_t_limit - socket.CMSG_SPACE(1) + 1
values = list(range(257)) + list(range(toobig - 257, toobig))
values = list(range(257)) + list(range(toobig - 257, toobig - 8))
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a 'fix' we are using internally, probably not acceptable (more in the issue tracker).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What are the values ofsocklen_t_limit andsocket.CMSG_SPACE(1) on Solaris?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Well, I think that the simplest way to resolve this is to add Solaris-specific fix:

Suggested change
values=list(range(257))+list(range(toobig-257,toobig-8))
ifSOLARIS:
toobig-=8
values=list(range(257))+list(range(toobig-257,toobig))

@serhiy-storchakaserhiy-storchaka changed the titlebpo-47058: Skip tests failing on Solarisgh-91214: Skip tests failing on SolarisFeb 23, 2024
@kulikjakkulikjakmannequin mentioned this pull requestApr 10, 2022
@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes and removed needs backport to 3.11only security fixes labelsMay 9, 2024
@tomasr8tomasr8 removed the needs backport to 3.12only security fixes labelApr 10, 2025
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.14bugs and security fixes labelMay 8, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka left review comments

Assignees
No one assigned
Labels
awaiting reviewneeds backport to 3.13bugs and security fixesneeds backport to 3.14bugs and security fixesskip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@kulikjak@serhiy-storchaka@tomasr8@the-knights-who-say-ni@ezio-melotti@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp