Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46644: Fix test_typing test broken by GH-31151 due to a merge race#31833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 1 commit intopython:mainfromJelleZijlstra:fixtyping
Mar 12, 2022

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMar 12, 2022•
edited by bedevere-bot
Loading

@vstinner
Copy link
Member

"fix test" is not a great commit title, it doesn't help future developers who will read commits. Would you mind to elaborate that?

Which test? Why was it failing? Is it related to a recent change? etc.

@JelleZijlstraJelleZijlstra changed the titlebpo-46644: fix testbpo-46644: Fix test_typing test broken by GH-31151 due to a merge raceMar 12, 2022
@JelleZijlstra
Copy link
MemberAuthor

Good point, how is the new title?

@vstinner
Copy link
Member

Good point, how is the new title?

Much better. Practical issue: be careful when you click on the Merge button, GitHub uses the commit title and commit message from Git, not the one on the web page. It's confusing. You can fix it with the form open by GitHub.

I avoid the automerge label to avoid this trap.

@JelleZijlstra
Copy link
MemberAuthor

Yes, I always read over the commit message when I merge :)

@JelleZijlstraJelleZijlstra merged commit7517437 intopython:mainMar 12, 2022
@JelleZijlstraJelleZijlstra deleted the fixtyping branchMarch 12, 2022 02:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@JelleZijlstra@vstinner@the-knights-who-say-ni@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp