Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
Remove new line in pickle error message#31782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
harshil21 commentedJun 5, 2022
Hi, is this change going to be implemented? If not, I'll just close. |
bedevere-bot commentedSep 6, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
nanjekyejoannah left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I doubt we need a news entry for this. Also docs seem to be failing.
harshil21 commentedOct 8, 2022
I think it's failing because there isn't an issue for this PR. Maybe I should delete the NEWS.d entry then? |
nanjekyejoannah left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, remove the news entry
bedevere-bot commentedOct 11, 2022
Most changes to Pythonrequire a NEWS entry. Please add it using theblurb_it web app or theblurb command-line tool. |
iritkatriel commentedNov 6, 2022
@serhiy-storchaka - as someone who's been looking at pickle issue recently, do you see any problem with this change? Does it need a news entry? |
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is a very old code. It was added infdde96c.
I do not know reasons of adding a newline at the first place, but the change LGTM.
Removes the new line in the error message. Encountered this while testing something and found it a little weird that there would be a new line character when the error message is short anyway.