Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46841: Add a_Py_SET_OPCODE macro#31780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 2 commits intopython:mainfrombrandtbucher:set-opcode
Mar 12, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucherbrandtbucher commentedMar 9, 2022•
edited by bedevere-bot
Loading

Now that we don't modify opargs anymore, this is a cleaner (and slighly more efficient) way of performing this common move.

https://bugs.python.org/issue46841

Copy link
Member

@markshannonmarkshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The C compiler is allowed to assume that foruint8_t *p1,_Py_CODEUNIT *p2,p1 andp2 don't alias. If you add the specialchar * cast, then it cannot make that (in this case false) assumption.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@markshannon
Copy link
Member

LGTM, apart from the missing cast.

@brandtbucherbrandtbucher merged commita89c29f intopython:mainMar 12, 2022
@brandtbucherbrandtbucher deleted the set-opcode branchJuly 21, 2022 19:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonmarkshannon requested changes

@sweeneydesweeneydesweeneyde left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@brandtbucher@bedevere-bot@markshannon@sweeneyde@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp