NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-46841: Fix`BINARY_OP`'s handling of inline caches#31671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

brandtbucher merged 2 commits intopython:mainfrombrandtbucher:binary-op-fix

Mar 4, 2022

Merged

bpo-46841: Fix`BINARY_OP`'s handling of inline caches#31671

brandtbucher merged 2 commits intopython:mainfrombrandtbucher:binary-op-fix

Mar 4, 2022

Conversation

Copy link

Member

brandtbucher commentedMar 3, 2022•
edited by bedevere-bot
Loading

https://bugs.python.org/issue46841

brandtbucher added2 commits

March 3, 2022 14:30

Handle cache entries correctly in BINARY_OP

fac0477

blurb add

f5d3c19

brandtbucher requested a review frommarkshannon as acode owner

March 3, 2022 22:36

bedevere-bot added the awaiting core review label

Mar 3, 2022

the-knights-who-say-ni added the CLA signed label

Mar 3, 2022

brandtbucher mentioned this pull request

Mar 3, 2022

Inline cachingfaster-cpython/ideas#310

Closed

26 tasks

Copy link

Member

markshannon commentedMar 4, 2022

Changes LGTM.

OOI, how did you find this?

Would it be feasible to add a regression test?

Copy link

MemberAuthor

brandtbucher commentedMar 4, 2022

OOI, how did you find this?

After theLOAD_FAST__LOAD_ATTR_INSTANCE_VALUE issue on#31640, I went through both these files and reviewed our use of instruction pointers.#31664 came out of that too.

Would it be feasible to add a regression test?

Not until we candis quickened code. Once that happens, I can go through and add a new suite of test cases for all of our adaptive/specialized/super instructions.

Don't worry, it will be less liketest_dis.py and more liketest_peepholer.py. ;)