NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

bpo-46841: Improve the failure stats for`COMPARE_OP`#31663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

brandtbucher merged 2 commits intopython:mainfrombrandtbucher:more-compare-op-stats

Mar 3, 2022

Merged

bpo-46841: Improve the failure stats for`COMPARE_OP`#31663

brandtbucher merged 2 commits intopython:mainfrombrandtbucher:more-compare-op-stats

Mar 3, 2022

Conversation

Copy link

Member

brandtbucher commentedMar 3, 2022•
edited by bedevere-bot
Loading

With the move to inline caching, jumps are getting a bit longer. This adds new category ofCOMPARE_OP failures for the (increasingly more common) case where aCOMPARE_OP instruction is followed by anEXTENDED_ARG.

New stats for a fullpyperformance run:

Kind	Count	Ratio
unquickened	7348739	0.4%
specialization.deferred	359371048	21.7%
specialization.deopt	15730	0.0%
hit	1289210975	77.8%
miss	943057	0.1%

Specialization attempts

	Count	Ratio
Success	289083	4.8%
Failure	5723386	95.2%

Failure kind	Count	Ratio
extended arg	`2473174`	43.2%
not followed by cond jump	1258612	22.0%
float long	671682	11.7%
set	579241	10.1%
different types	165539	2.9%
bool	137038	2.4%
tuple	119632	2.1%
other	115566	2.0%
big int	95547	1.7%
bytes	46481	0.8%
baseobject	37335	0.7%
list	22634	0.4%
string	704	0.0%
long float	201	0.0%

https://bugs.python.org/issue46841

brandtbucher added2 commits

March 3, 2022 10:44

Improve the failure stats for COMPARE_OP

3c2c673

blurb add

1036d0d

brandtbucher requested review frommarkshannon andsweeneyde

March 3, 2022 18:55

bedevere-bot added the awaiting core review label

Mar 3, 2022

the-knights-who-say-ni added the CLA signed label

Mar 3, 2022

sweeneyde approved these changes

Mar 3, 2022

View reviewed changes

Copy link

Member

sweeneyde left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good.

We could also consider packing extended opargs into the top 13 bits ofcache->mask when it fits there.

Edit: I suppose it would be difficult to do next_instr++ the correct number of times in ceval. Store how far to jump ahead for that branch as well?

bedevere-bot added awaiting merge and removed awaiting core review labels

Mar 3, 2022

brandtbucher mentioned this pull request

Mar 3, 2022

Inline cachingfaster-cpython/ideas#310

Closed

26 tasks

Copy link

MemberAuthor

brandtbucher commentedMar 3, 2022

@markshannon is already brainstorming ideas for how to tackle the general problem of longer jumps infaster-cpython/ideas#297 andfaster-cpython/ideas#301. We should probably wait to see how that pans out first before adding a bunch of new logic to the differentCOMPARE_OP specializations.