NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-91038: Change default argument value to`False` instead of`0`#31621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 3 commits intopython:mainfromRotzbua:change_default_value_platform_platform

Feb 27, 2023

Merged

gh-91038: Change default argument value to`False` instead of`0`#31621

JelleZijlstra merged 3 commits intopython:mainfromRotzbua:change_default_value_platform_platform

Feb 27, 2023

Conversation

Copy link

Contributor

Rotzbua commentedFeb 28, 2022•
edited by bedevere-bot
Loading

The argument is used as a switch and corresponds to a boolean logic. Therefore it is more intuitive to use the corresponding constantFalse as default value instead of the integer0.

https://bugs.python.org/issue46882

Issue:Clarify argument type of platform.platform(aliased, terse) to boolean #91038

Change default argument value toFalse instead of0

513d84d

The argument is used as a switch and corresponds to a boolean logic. Therefore it is more intuitive to use the corresponding constant `False` as default value instead of the integer `0`.

bedevere-bot added the awaiting review label

Feb 28, 2022

the-knights-who-say-ni added the CLA signed label

Feb 28, 2022

ezio-melotti removed the CLA signed label

Jul 13, 2022

JelleZijlstra self-assigned this

Oct 6, 2022

JelleZijlstra requested changes

Oct 6, 2022

View reviewed changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I agree this is an improvement, but I think it deserves a NEWS entry. Could you add one?

bedevere-bot removed the awaiting review label

Oct 6, 2022

Copy link

bedevere-bot commentedOct 6, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label

Oct 6, 2022

JelleZijlstra mentioned this pull request

Oct 6, 2022

bpo-46882: Clarify argument type of platform.platform(aliased, terse) to boolean#31617

Closed

JelleZijlstra removed their assignment

Nov 12, 2022

Merge branch 'main' into change_default_value_platform_platform

9382424

Copy link

bedevere-bot commentedFeb 26, 2023

Most changes to Pythonrequire a NEWS entry.

Please add it using theblurb_it web app or theblurb command-line tool.

arhadthedev changed the title~~bpo-46882: Change default argument value toFalse instead of0~~gh-91038: Change default argument value toFalse instead of0

Feb 26, 2023

arhadthedev added docs

Documentation in the Doc dir

stdlibPython modules in the Lib dir labels

Feb 26, 2023

Add a news entry

5de86dd

arhadthedev requested a review fromJelleZijlstra

February 26, 2023 08:38

Copy link

Member

arhadthedev commentedFeb 26, 2023

@JelleZijlstra I have made the requested changes; please review again

JelleZijlstra approved these changes

Feb 27, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting changes labels

Feb 27, 2023

JelleZijlstra merged commitf3cb15c intopython:main

Feb 27, 2023

bedevere-bot removed the awaiting merge label

Feb 27, 2023

Rotzbuamannequin mentioned this pull request

Apr 10, 2022

Clarify argument type of platform.platform(aliased, terse) to boolean#91038

Closed

carljm added a commit to carljm/cpython that referenced this pull request

Feb 28, 2023

Merge branch 'main' into inlinecomp2

73dc0ed

* main: (67 commits)pythongh-99108: Add missing md5/sha1 defines to Modules/Setup (python#102308)pythongh-100227: Move _str_replace_inf to PyInterpreterState (pythongh-102333)pythongh-100227: Move the dtoa State to PyInterpreterState (pythongh-102331)pythonGH-102305: Expand some macros in generated_cases.c.h (python#102309)  Migrate to new PSF mailgun account (python#102284)pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) (python#102193)pythonGH-90744: Fix erroneous doc links in the sys module (python#101319)pythongh-87092: Make jump target label equal to the offset of the target in the instructions sequence (python#102093)pythongh-101101: Unstable C API tier (PEP 689) (pythonGH-101102)  IDLE: Simplify DynOptionsMenu __init__code (python#101371)pythongh-101561: Add typing.override decorator (python#101564)pythongh-101825: Clarify that as_integer_ratio() output is always normalized (python#101843)pythongh-101773: Optimize creation of Fractions in private methods (python#101780)pythongh-102251: Updates to test_imp Toward Fixing Some Refleaks (pythongh-102254)pythongh-102296 Document that inspect.Parameter kinds support ordering (pythonGH-102297)pythongh-102250: Fix double-decref in COMPARE_AND_BRANCH error case (pythonGH-102287)pythongh-101100: Fix sphinx warnings in `types` module (python#102274)pythongh-91038: Change default argument value to `False` instead of `0` (python#31621)pythongh-101765: unicodeobject: use Py_XDECREF correctly (python#102283)  [doc] Improve grammar/fix missing word (pythonGH-102060)  ...