Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46841: Use *inline* caching forBINARY_OP#31543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
markshannon merged 8 commits intopython:mainfrombrandtbucher:inline-caches
Feb 25, 2022

Conversation

brandtbucher
Copy link
Member

@brandtbucherbrandtbucher commentedFeb 24, 2022•
edited by bedevere-bot
Loading

Here's a sort-of-rough first pass at implementing this idea.BINARY_OP is easy to start with, since it only uses its cache for the adaptivecounter member. Initial perf testing doesn't show any impact, which I think is good (it means that the basic idea works well, even when the cacheisn't being used).

Related changes:

  • All of thedis utilities grow ashow_caches parameter, defaulting toFalse.
  • wordcode_helpers.h has been moved intocompile.c.

https://bugs.python.org/issue46841

@@ -24,6 +24,12 @@ interpreter.
Use 2 bytes for each instruction. Previously the number of bytes varied
by instruction.

.. versionchanged:: 3.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe don't document this until we are sure it's what we want?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd prefer to keep it, and change it if/whendis changes (which is easy enough). That way we don't forget to document it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OK. Once we've started doing this we will need to complete it before the beta release anyway.

@markshannon
Copy link
Member

Looks good in general.
I've commented onhttps://bugs.python.org/issue46841 about what interface we want to add to the dis module.

@brandtbucherbrandtbucher added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 24, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@brandtbucher for commit1aa079c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 24, 2022
@markshannon
Copy link
Member

👍
Let the process of inlining the caches commence

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@brandtbucher@markshannon@bedevere-bot@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp