Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46586: Fix more erroneous doc links to builtins#31429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 8 commits intopython:mainfrommeersuri:fix-issue-46586
May 2, 2022

Conversation

meersuri
Copy link
Contributor

@meersurimeersuri commentedFeb 19, 2022•
edited by bedevere-bot
Loading

@AlexWaygood
Copy link
Member

Hi, it looks like you need to mergeorigin/main into your branch here — theenum.property fix is still showing up in this PR, even though that one's already been committed tomain 🙂

meersuri reacted with thumbs up emoji

Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Éric <merwok@netwok.org>
@merwok
Copy link
Member

merwok commentedMay 2, 2022•
edited
Loading

Thanks for this PR!
Could we also fix the wrong markup in the documentation of structseq objects? (see#90744 (comment))

@JelleZijlstra
Copy link
Member

@merwok let's keep that for another PR, so we can land this one.

AlexWaygood reacted with thumbs up emoji

@merwok
Copy link
Member

I don’t really get why split these fixes into three changes here, two changes there (and the original ticket aboutenum has already had its scope widered), but 🤷🏽 it’s up to you! Better to merge some fixes than none 🙂

@JelleZijlstraJelleZijlstra merged commitcc6ae4f intopython:mainMay 2, 2022
@miss-islington
Copy link
Contributor

Thanks@meersuri for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 2, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Éric <merwok@netwok.org>(cherry picked from commitcc6ae4f)Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@miss-islington
Copy link
Contributor

Sorry,@meersuri and@JelleZijlstra, I could not cleanly backport this to3.9 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker cc6ae4f4835f9e76a34f24cd1f666c1cc0fecfa3 3.9

@bedevere-bot
Copy link

GH-92198 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelMay 2, 2022
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull requestMay 2, 2022
…1429)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Éric <merwok@netwok.org>.(cherry picked from commitcc6ae4f)Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@bedevere-botbedevere-bot removed the needs backport to 3.9only security fixes labelMay 2, 2022
@bedevere-bot
Copy link

GH-92199 is a backport of this pull request to the3.9 branch.

miss-islington added a commit that referenced this pull requestMay 2, 2022
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Éric <merwok@netwok.org>(cherry picked from commitcc6ae4f)Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
JelleZijlstra added a commit that referenced this pull requestMay 3, 2022
…92199)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Éric <merwok@netwok.org>.(cherry picked from commitcc6ae4f)Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
…1429) (python#92199)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Éric <merwok@netwok.org>.(cherry picked from commitcc6ae4f)Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood left review comments

@ethanfurmanethanfurmanAwaiting requested review from ethanfurman

Assignees

@JelleZijlstraJelleZijlstra

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@meersuri@AlexWaygood@merwok@JelleZijlstra@miss-islington@bedevere-bot@hugovk@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp