Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
bpo-46752: Slight improvements to TaskGroup API#31398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We're not sure that they are needed, and once in the codewe would never be able to get rid of them.Yury wrote:> Ideally, there should be a way for someone to build a "trace"> of taskgroups/task leading to the current running task.> We could do that using contextvars, but I'm not sure we should> do that in 3.11.
1st1 approved these changesFeb 18, 2022
gvanrossum added a commit to python/typeshed that referenced this pull requestFeb 18, 2022
* Remove TaskGroup name arg and get_name() method(We removed those from the implementation.)* Add optional name arg to create_task()Seepython/cpython#31398
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Note that there's a big discussion on cancellation edge cases going on inbpo-46771, this is unrelated to that and uncontroversial.
I'll also update typeshed.
https://bugs.python.org/issue46752