Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-34526:[doc] Add description and examples of multiple arguments for Path.relative_to#31368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

lvluling
Copy link

@lvlulinglvluling commentedFeb 16, 2022
edited by bedevere-bot
Loading

the docs for Path.relative_to is a bit confusing why other is a star-args, especially as no example actually passes more than one argument to relative_to

https://bugs.python.org/issue34526

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@lvluling

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

*other*. If it's impossible, ValueError is raised::
Return the relative path to another path identified by *other*, each
element of *other* can be either a string representing a path segment,
or another path object implementing the :class:`PurePath`(or a subclass
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks. You missed the definition ofclass PurePath in the context, it could be changed from :class:PurePath to the classPurePath.

@JelleZijlstra
Copy link
Member

@barneygale would you be able to review this PR?

barneygale reacted with thumbs up emoji

@barneygale
Copy link
Contributor

barneygale commentedMay 2, 2022
edited
Loading

I've left a comment on the#78707. I don't thinkrelative_to() andis_relative_to() should accept multiple arguments - I'd rather we restricted this to methods thatexplicitly deal with path construction -PurePath() andPurePath.joinpath().

JelleZijlstra reacted with thumbs up emoji

@barneygale
Copy link
Contributor

In#94469 we deprecated passing multiple positional arguments torelative_to(), so I think this patch is no longer valid. Thank you for working on it all the same!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@CharlieZhao95CharlieZhao95CharlieZhao95 left review comments

Assignees
No one assigned
Labels
awaiting reviewdocsDocumentation in the Doc dirskip newstopic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9 participants
@lvluling@the-knights-who-say-ni@JelleZijlstra@barneygale@CharlieZhao95@hauntsaninja@ezio-melotti@bedevere-bot@AlexWaygood

[8]ページ先頭

©2009-2025 Movatter.jp