🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit1555087 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Yeah, I like this!

How about error handling when printing the traceback? Should we print something like "cannot printnotes: not a sequence", and similarly if a note is not a str?

How about error handling when printing the traceback? Should we print something like "cannot printnotes: not a sequence", and similarly if a note is not a str?

How about printingrepr(self.__notes__) if it's not a list, andstr(note) if an individual note isn't a string? The former makes it clear what itis, while the latter provides a feature that Barry has been asking for...

If either of those fails, either raise an exception fromprint_exception() or swallow the error and print a simple message. It probably doesn't really matter,repr() orstr() failing should be extremely obscure.

How about error handling when printing the traceback? Should we print something like "cannot printnotes: not a sequence", and similarly if a note is not a str?

How about printingrepr(self.__notes__) if it's not a list, andstr(note) if an individual note isn't a string? The former makes it clear what itis, while the latter provides a feature that Barry has been asking for...

If either of those fails, either raise an exception fromprint_exception() or swallow the error and print a simple message. It probably doesn't really matter,repr() orstr() failing should be extremely obscure.

I'll do something likewhat we do for str(exc).

Heya - I think we should have an explicit test that if you.split() anExceptionGroup which already has__notes__, it's shallow-copied rather than simply assigned to the new instances. It'd be pretty confusing to call.add_note() on one and have it added to other instances too!

Heya - I think we should have an explicit test that if you.split() anExceptionGroup which already has__notes__, it's shallow-copied rather than simply assigned to the new instances. It'd be pretty confusing to call.add_note() on one and have it added to other instances too!

That's a good point. I added the test and fixed the code to copy the notes in split(), so long as they are a sequence (producing a list). If people assign arbitrary objects to notes I don't know how to copy them.
Is there a "copy protocol" we can demand?

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit95be670 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

Sorry about the noise (I messed it up multitasking). Getting there now.

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit602b4c4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

The buildbots are happy with this. Let me know if you would like to re-review, otherwise I'll merge it tomorrow or so.