Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-46659: Fix the MBCS codec alias on Windows#31218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@eryksun: Does this approach look good to you? It's basically restores Python 3.10 behavior. I just adjusted the test. |
Lib/test/test_codecs.py Outdated
self.assertEqual(codec.name, "mbcs") | ||
# Check that looking up our 'default' codepage will return | ||
# mbcs when we don't have a more specific one available | ||
code_page = 9999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Let's use 99999 instead, which is beyond the range of anything that Python might ever define. Seecode page identifiers.
eryksun commentedFeb 8, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, having a fallback for the process ANSI code page is for the best -- even though we support all of the known code pages in standard Windows locales. Thank you for clarifying the reason for its existence in the comments. I'd prefer to also have a fallback to "oem" for the process OEM code page, but adding |
Thanks@eryksun for your review. My use case is to deprecate the locale.getdefaultlocale() function. Adding an alias for the OEM page code is unrelated. If you consider that it's an useful feature, you can open a separated PR. So far, nobody requested it, so maybe it's not needed. I'm not convinced that the fallbak for the ANSI code page is used by anyone. |
I don't know whether the ANSI fallback is used by anyone. As I said, I've never worked with supplemental/replacementcustom locales. The suggestion can be shelved until someone has an issue or explicitly requests a fallback for OEM as something required for their work environment. |
It sounds perfectly reasonable :-) |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue46659