NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-46659: Deprecate locale.getdefaultlocale()#31206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:deprecate_getdefaultlocale

Feb 22, 2022

Merged

bpo-46659: Deprecate locale.getdefaultlocale()#31206

vstinner merged 1 commit intopython:mainfromvstinner:deprecate_getdefaultlocale

Feb 22, 2022

Conversation

Copy link

Member

vstinner commentedFeb 7, 2022•
edited
Loading

The locale.getdefaultlocale() function is deprecated and will be removed in
Python 3.13. Use locale.setlocale(),
locale.getpreferredencoding(False) and locale.getlocale() functions
instead.

https://bugs.python.org/issue46659

the-knights-who-say-ni added the CLA signed label

Feb 7, 2022

bedevere-bot added the awaiting core review label

Feb 7, 2022

vstinner changed the title~~bpo-43557: Deprecate locale.getdefaultlocale()~~bpo-46659: Deprecate locale.getdefaultlocale()

Feb 8, 2022

Copy link

MemberAuthor

vstinner commentedFeb 8, 2022

cc@serhiy-storchaka @methane

Copy link

Member

methane commentedFeb 9, 2022

Locale is too difficult to me, so I can not say LGTM.
At least, I feel it is very tempting API that can be used to get preferred language without calling setlocale()...

Copy link

MemberAuthor

vstinner commentedFeb 11, 2022•
edited
Loading

At least, I feel it is very tempting API that can be used to get preferred language without calling setlocale()...

The function is convenient until you fall into a case where it doesn't work as expected. It's similar to mixing Python 2 str and unicode types. It works in most cases, until someone enters a name with a single non-ASCII character, and then suddently everything fall apart.