Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-46679: Don't ignore timeout argument in test.support.wait_process.#31205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
bpo-46679: Don't ignore timeout argument in test.support.wait_process.#31205
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -0,0 +1,2 @@ | |||
| The function ``wait_process`` in ``Lib/test/support/__init__.py`` no longer | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
NEWS are not required for test-only changes. We need them for user-facing changes only 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good to know! Thanks! :)
@kumaraditya303 Done. :) |
The wait_process function has changed significantly since your changes in the latest 3.12 could you please check? |
I fixed this issue with commit0ba8027. But IMO it's still interesting to fix this typo in Python 3.10 and 3.11. Can you please create a PR for the 3.11 branch? |
Closing as it is fixed on main. If you are interested, feel free to create 3.11 backport as Victor suggested. |
Uh oh!
There was an error while loading.Please reload this page.
The function
wait_processinLib/test/support/__init__.pyignores itstimeoutargument. This argument is useful, for example, in tests that need to determine whether a deadlock has been fixed (e.g., the test added in#30310).https://bugs.python.org/issue46679