Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46648: movetest_issue16464 tourllib2_localnet#31186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromsobolevn:issue-46648
Feb 7, 2022

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commentedFeb 7, 2022•
edited by bedevere-bot
Loading

I moved the flaky test totest_urllib2_localnet as@gpshead suggested.
I hope that it will now be reliable 🎉

https://bugs.python.org/issue46648

GBeauregard reacted with hooray emoji
@vstinnervstinner merged commit8e98175 intopython:mainFeb 7, 2022
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 7, 2022
…erver (pythonGH-31186)Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnetand use the local HTTP server rather than an external HTTP server.(cherry picked from commit8e98175)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

GH-31189 is a backport of this pull request to the3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10only security fixes labelFeb 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 7, 2022
…erver (pythonGH-31186)Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnetand use the local HTTP server rather than an external HTTP server.(cherry picked from commit8e98175)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@vstinner
Copy link
Member

PR merged, thanks. I rewrote the commit title/description.

@bedevere-bot
Copy link

GH-31190 is a backport of this pull request to the3.9 branch.

miss-islington added a commit that referenced this pull requestFeb 7, 2022
…erver (GH-31186)Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnetand use the local HTTP server rather than an external HTTP server.(cherry picked from commit8e98175)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull requestFeb 7, 2022
… HTTP server (GH-31186) (GH-31189)Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnetand use the local HTTP server rather than an external HTTP server.(cherry picked from commit8e98175)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@miss-islington
Copy link
Contributor

Thanks@sobolevn for the PR, and@vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@sobolevn and@vstinner, I could not cleanly backport this to3.8 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 8e98175a03fe03d62822d96007a74e5273013764 3.8

@ambv
Copy link
Contributor

ambv commentedFeb 8, 2022

OK, nevermind, I'll useGH-31173 instead.

hello-adam pushed a commit to hello-adam/cpython that referenced this pull requestJun 2, 2022
…erver (pythonGH-31186)Re-enable test_issue16464() of test_urllib2, move it to urllib2_localnetand use the local HTTP server rather than an external HTTP server.(cherry picked from commit8e98175)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gpsheadgpsheadgpshead approved these changes

@vstinnervstinnerAwaiting requested review from vstinner

+1 more reviewer

@raghavthind2005raghavthind2005raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vstinnervstinner

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sobolevn@miss-islington@bedevere-bot@vstinner@ambv@gpshead@raghavthind2005@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp