Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org#31146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vstinner wants to merge1 commit intopython:mainfromvstinner:urllib2_issue16464
Closed

bpo-46648: test_urllib2.test_issue16464() uses httpbin.org#31146

vstinner wants to merge1 commit intopython:mainfromvstinner:urllib2_issue16464

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedFeb 5, 2022•
edited by bedevere-bot
Loading

The test_issue16464() test of test_urllib2 now uses
"http://httpbin.org/post" URL instead of "http://www.example.com/".

https://bugs.python.org/issue46648

The test_issue16464() test of test_urllib2 now uses"http://httpbin.org/post" URL instead of "http://www.example.com/".
@vstinner
Copy link
MemberAuthor

cc@corona10@ambv

Copy link
Member

@tirantiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@vstinner
Copy link
MemberAuthor

Please use a different, more reliable service. The git repo and container image of the service hasn't been maintained in years.

test_urllib2 is failing on all buildbots right now because example.com is no longer reliable. Do you have a better suggestion?

I'm not aware of any pythontest.net URL supporting POST.

Either we switch to any other URL or the test should be skipped. Most buildbots are failing.

@orsenthil
Copy link
Member

Hi@vstinner, I am with@tiran here. If possible m we should use pythontest . I think, it supports simple post.

If blocked by external resources, we can skip the test. BTW test_urllib2net is supposed to depend on external sources. The test_urllib2 should have mocks.

@vstinnervstinner deleted the urllib2_issue16464 branchFebruary 6, 2022 14:09
@vstinner
Copy link
MemberAuthor

I merged my PR#31161 instead (skip the test).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tirantirantiran requested changes

Assignees

No one assigned

Labels

awaiting changestestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@bedevere-bot@orsenthil@tiran@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp