Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-46598: Fix ElementTree.write XML prolog for encoding 'utf-8-sig'#31043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
When ElementTree object is to be written to the file, and when BOMis needed, the 'utf-8-sig' can be used for the purpose.However, the XML prolog then looks like...<?xml version='1.0' encoding='utf-8-sig'?>... and that encoding in the prolog makes no sense. Therefore,the utf-8-sig is changed to utf-8 for the purpose.
the-knights-who-say-ni commentedFeb 1, 2022
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue. You cancheck yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
pepr commentedFeb 1, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hello all, Finally, I have found how to add my GitHub name to the b.p.o. Done. I have also signed the PSF contributor agreement. Thebpo-46598 was created, and the PR at b.p.o linked was added to point here. The pull-request changes should be easily understandable, and I have tried it on my local computer. Have a nice day, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add the NEW.d for behavior changing
bedevere-bot commentedFeb 2, 2022
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
@corona10: Sorry, I am new in this workflow. What does it mean the "add the NEW.d for behavior changing"? Is it expected from me? |
Thanks. You need to include a NEWS entry to describe the change. Also, this needs a test. See the ElementTree tests under Lib/test/ There are already some that deal with encodings and the XML prologue. |
Uh oh!
There was an error while loading.Please reload this page.
bpo-46598: Fix ElementTree.write XML prolog for encoding 'utf-8-sig'
When ElementTree object is to be written to the file, and when BOM
is needed, the 'utf-8-sig' can be used for the purpose.
However, the XML prolog then looks like...
... and that encoding in the prolog makes no sense. Therefore,
the
utf-8-sig
is changed toutf-8
for the purpose.https://bugs.python.org/issue46598