Here's a slightly evil corner case that this patch doesn't account for:

If I have a moduletyping_test.py, like so:

# typing_test.pyclassA:classAA:foo:int

Then, observe the following behaviour (with your patch applied):

>>>fromtypingimportget_type_hints,no_type_check>>>importtyping_test>>>get_type_hints(typing_test.A.AA){'foo':<class'int'>}>>> @no_type_check...classA:...AA=typing_test.A.AA... ...>>>get_type_hints(typing_test.A.AA){}

We might be able to get around this by looking at the__module__ attribute.

@AlexWaygood good one! Very evil!

I've addressed this.

@JelleZijlstra I agree that we should also fixclassmethod /staticmethod problem. Because we declare to support all methods, not just instance methods.

The problem is thattypes.MethodType does not support attribute assignment:

>>>classSome:...     @staticmethod...defst(x:int)->int: ......     @classmethod...defcl(cls,y:int)->int: ...>>>Some.st.__no_type_check__=True>>>Some.cl.__no_type_check__=TrueAttributeError:'method'objecthasnoattribute'__no_type_check__'

Ideas?

Moreover, do we need some special@property support?

@AlexWaygood good one! Very evil!

I've addressed this.

Doesn't look like you've pushed anything -- did you mean to? :)

Doesn't look like you've pushed anything -- did you mean to? :)

Not yet, I am still fightingclassmethod 🙂

Probably

ifisinstance(obj,types.MethodType):obj.__func__.__no_type_check__=True

is the way to go 🤔

Will write some more tests to be sure.