NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-46556: emit`DeprecationWarning` from`pathlib.Path.enter()`#30971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

brettcannon merged 6 commits intopython:mainfrombarneygale:bpo-46556-deprecate-pathlib-path-enter

Feb 8, 2022

Merged

bpo-46556: emit`DeprecationWarning` from`pathlib.Path.enter()`#30971

brettcannon merged 6 commits intopython:mainfrombarneygale:bpo-46556-deprecate-pathlib-path-enter

Feb 8, 2022

+20 −12

Conversation

Copy link

Contributor

barneygale commentedJan 27, 2022•
edited by brettcannon
Loading

In Python 3.9,Path.__exit__() was made a no-op.

https://bugs.python.org/issue46556

Automerge-Triggered-By: GH:brettcannon

bpo-46556: emitDeprecationWarning frompathlib.Path.__enter__()

c53f031

In Python 3.9 / bpo-39682 we made `Path.__exit__()` a no-op, and added acomment in the code mentioning that it should be deprecated in future. Thefuture is here, so let's deprecate it.

the-knights-who-say-ni added the CLA signed label

Jan 27, 2022

bedevere-bot added the awaiting review label

Jan 27, 2022

sobolevn reviewed

Jan 28, 2022

View reviewed changes

Lib/pathlib.pyShow resolvedHide resolved

Test that using a path as a context manager raisesDeprecationWarning

6bf4483

brettcannon self-requested a review

January 28, 2022 18:26

Tweak comment in__enter__()

6e086f8

tirkarthi reviewed

Jan 30, 2022

View reviewed changes

Copy link

Member

tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There are deprecation warnings emitted by other tests too :

./python -Wall -m test test_pathlib         0:00:00 load avg: 0.37 Run tests sequentially0:00:00 load avg: 0.37 [1/1] test_pathlib/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.  with p:/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.  with p:/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.  with p:/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.  with p:== Tests result: SUCCESS ==1 test OK.Total duration: 586 msTests result: SUCCESS