Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-23952: Document cgi module's maxlen variable#30338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ethanfurman merged 3 commits intopython:mainfromhugovk:23952-cgi-document-maxlen
Feb 6, 2022

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commentedJan 2, 2022
edited by bedevere-bot
Loading

Using the text suggested inhttps://bugs.python.org/issue23952.

I think this documentation-only change can skip a NEWS file.

https://bugs.python.org/issue23952

Copy link
Contributor

@rhettingerrhettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is a good start. Please also update the main docs atDocs/library/cgi.rst.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@rhettingerrhettinger added skip news docsDocumentation in the Doc dir labelsJan 2, 2022
@hugovk
Copy link
MemberAuthor

This is a good start. Please also update the main docs atDocs/library/cgi.rst.

Updated!

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger: please review the changes made to this pull request.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hugovk
Copy link
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@rhettinger,@ethanfurman: please review the changes made to this pull request.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 2, 2022
@ethanfurmanethanfurman added 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section and removed staleStale PR or inactive for long period of time. labelsFeb 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@ethanfurman for commit90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 5, 2022
@hugovk
Copy link
MemberAuthor

test_issue16464 (test.test_urllib2.MiscTests) ... ERROR failed withurllib.error.HTTPError: HTTP Error 404: Not Found.

Details
test_issue16464 (test.test_urllib2.MiscTests) ... ERROR======================================================================ERROR: test_issue16464 (test.test_urllib2.MiscTests)----------------------------------------------------------------------Traceback (most recent call last):  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/contextlib.py", line 155, in __exit__    self.gen.throw(typ, value, traceback)    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/support/socket_helper.py", line 245, in transient_internet    yield    ^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/test/test_urllib2.py", line 1803, in test_issue16464    opener.open(request, "1234567890".encode("us-ascii"))    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 525, in open    response = meth(req, response)               ^^^^^^^^^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 634, in http_response    response = self.parent.error(               ^^^^^^^^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 563, in error    return self._call_chain(*args)           ^^^^^^^^^^^^^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 496, in _call_chain    result = func(*args)             ^^^^^^^^^^^  File "/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z.refleak/build/Lib/urllib/request.py", line 643, in http_error_default    raise HTTPError(req.full_url, code, msg, hdrs, fp)    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^urllib.error.HTTPError: HTTP Error 404: Not Found

https://buildbot.python.org/all/#/builders/217/builds/431/steps/5/logs/stdio

Likely unrelated to this docs change, so rescheduling.

@hugovkhugovk added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 5, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@hugovk for commit90442ca 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelFeb 5, 2022
@hugovk
Copy link
MemberAuthor

Same thing. Thetest_issue16464 failure is unrelated;https://bugs.python.org/issue46648 /#31146 /#31148.

@ethanfurmanethanfurman merged commit6c4e44e intopython:mainFeb 6, 2022
@hugovkhugovk deleted the 23952-cgi-document-maxlen branchFebruary 6, 2022 15:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@ethanfurmanethanfurmanethanfurman approved these changes

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hugovk@bedevere-bot@rhettinger@ethanfurman@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp